Dynamic Tags - Escaped character handling #1543
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iansvo
changed the title
Base automatically changed from
refactor/dynamic-tag-parser
to
release/2.0.0
November 28, 2024 14:07
|
@iansvo As of right now, what issue is this PR solving? Or is it just for future use? |
|
We did this originally so someone could actually use a pipe character in the dynamic tag params and so we could accommodate the use of quotes. It just makes it easier for users to enter in values if they use characters that affect our parsing (we largely did this during a pair session before). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles using quotes and pipe characters in dynamic tags.