Address review comments

tonarino · Jun 20, 2024 · f0de388 · f0de388
1 parent 4449ae2
commit f0de388
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/shared/src/prompts.rs b/shared/src/prompts.rs
@@ -567,7 +567,9 @@ pub fn ask_endpoint(listen_port: u16) -> Result<Endpoint, Error> {
         publicip::get_any(Preference::Ipv4)
     } else if Confirm::with_theme(&*THEME)
         .wait_for_newline(true)
-        .with_prompt("You do not have a fixed global IP (use the unspecified address)?")
+        .with_prompt(
+            "Use an unspecified IP address? (this can occur if you do not have a fixed global IP)",
+        )
         .interact()?
     {
         Some(IpAddr::V6(Ipv6Addr::UNSPECIFIED))

diff --git a/shared/src/types.rs b/shared/src/types.rs
@@ -453,6 +453,8 @@ pub struct OverrideEndpointOpts {
     /// The external endpoint that you'd like the innernet server to broadcast
     /// to other peers. The IP address may be unspecified, in which case the
     /// server will try to resolve it based on its most recent connection.
+    /// The port will still be used even if you decide to use the unspecified
+    /// IP address.
     #[clap(short, long)]
     pub endpoint: Option<Endpoint>,