enable IPv6 NAT candidate reporting #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcginty
force-pushed
the
ipv6-nat-candidates
branch
from
0872f4f
to
06b58c2
Compare
mcginty
force-pushed
the
ipv6-nat-candidates
branch
from
06b58c2
to
d8d6a0a
Compare
strohel
reviewed
Feb 6, 2022
Comment on lines
+114
to
+115
| || matches!(ip, | ||
| IpAddr::V6(v6) if is_unicast_global(v6)) |
There was a problem hiding this comment.
This is a nice trick to concisely check something on an enum variant, I need to remember to use it, too.
(if only rustfmt didn't spoil it by being somewhat clueless with this expression)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes from the conversation in #191
previous behavior: filter out all IPv6 addresses from being reported as NAT candidates.
new behavior: Begin reporting IPv6 addresses that are global unicast scope only.
An argument could be made for also reporting unique local addresses as well, but I think it's less important and more likely to increase noise with little benefit to getting through any different types of NATs.
I'd love to hear from people more experienced with managing IPv6 addresses if that's not an appropriate strategy.