server: add better validation to the associations endpoint #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcginty
force-pushed
the
association-uniqueness
branch
from
b4e7add
to
393e788
Compare
mcginty
force-pushed
the
association-uniqueness
branch
from
393e788
to
dbf3436
Compare
strohel
reviewed
Feb 6, 2022
| &contents, | ||
| ) | ||
| .await; | ||
| assert!(!res.status().is_success()); |
There was a problem hiding this comment.
Super-nit: using .is_client_error() as already done above could be a tiny bit more descriptive here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the server didn't care too much about what the parameters for an association were - this adds more proper validation to the inputs to avoid any odd situations.