Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: re-attempt NAT traversal on all unconnected peers #195

Merged
merged 1 commit into from
Feb 2, 2022
Merged

client: re-attempt NAT traversal on all unconnected peers #195

merged 1 commit into from
Feb 2, 2022

Conversation

mcginty
Copy link
Collaborator

@mcginty mcginty commented Feb 1, 2022

fixes #173

@mcginty mcginty merged commit 6d26385 into main Feb 2, 2022
@mcginty mcginty deleted the nat-modification-fix branch February 2, 2022 16:49
strohel
strohel reviewed Feb 6, 2022
View reviewed changes
Copy link
Member

@strohel strohel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. I've tested this locally, but the the condition to trigger this case doesn't seem to be common?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strohel strohel strohel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When a peer isn't modified in fetch, NAT traversal doesn't attempt to re-establish a broken connection
2 participants
@mcginty @strohel