Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use stable clippy #239

Merged
merged 1 commit into from
Dec 1, 2022
Merged

CI: use stable clippy #239

merged 1 commit into from
Dec 1, 2022

Conversation

strohel
Copy link
Member

@strohel strohel commented Dec 1, 2022

Using nightly one leads to having to resolve lints more frequently than rust releases, which is getting inconvenient.

It also leads to a small compatibility issue with stable clippy: if we need to #[allow] a lint that is only present in nightly clippy, then stable clippy complains about unknown lint in the allow. 🤷

Using nightly one leads to having to resolve lints more frequently than rust releases, which is
getting inconvenient.

It also leads to a small compatibility issue with stable clippy: if we need to #[allow] a lint that
is only present in nightly clippy, then stable clippy complains about unknown ling in the `allow`.
Copy link
Member

@bschwind bschwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@strohel strohel merged commit 00c2b3c into main Dec 1, 2022
@strohel strohel deleted the stable-clippy branch December 1, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants