Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Feather Icons support #3

Merged
merged 2 commits into from
May 21, 2020
Merged

Conversation

pablo-lp
Copy link

Example:

Load feather lib js

$('[data-toggle="datetimepicker"]').datetimepicker({
        icons: {
		type: 'feather',
		time: 'clock',
		date: 'calendar',
		up: 'arrow-up',
		down: 'arrow-down',
		previous: 'arrow-left',
		next: 'arrow-right'
	}
});

feather.replace();

@tonix-tuft tonix-tuft merged commit 76a6826 into tonix-tuft:fork May 21, 2020
@tonix-tuft
Copy link
Owner

tonix-tuft commented May 21, 2020

Good job man! I have merged your branch into fork.

I really like those icons!

You can update your npm deps with npm update.

I have to say you that I had to modify some stuff, though (CSS styles, handle some edge cases, etc...).

When you will work on your next PR on this project (I hope you will 😃) could you please run the following command on the CLI:

$ npm run watch

?

And then implement your features until the build is green with the Done message.

This way we also make sure that we are consistent with the ESLint rules defined in the project.

Thank you and hope to hear from you again!

@tonix-tuft
Copy link
Owner

Good news man, the React port of this project has also been updated to support Feather icons!

Have a nice day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants