CI: Run on PRs and pushes to master #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the CI runs on PRs from external contributors as well. Previously it on run when the PR was raised from a branch in the main repo.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #83 +/- ##
=======================================
Coverage 98.44% 98.44%
=======================================
Files 121 121
Lines 4385 4385
=======================================
Hits 4317 4317
Misses 68 68 ☔ View full report in Codecov by Sentry. |
|
Looks reasonable to me. It seems Github also solved the issue of cryptomining PRs (3 years ago already). It's required to approve the pipeline for first time contributors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the CI runs on PRs from external contributors as well. Previously it on run when the PR was raised from a branch in the main repo.