Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is ligating www to a zigzag-line a good idea? #253

Open
Spontifixus opened this issue Aug 26, 2016 · 15 comments
Open

Is ligating www to a zigzag-line a good idea? #253

Spontifixus opened this issue Aug 26, 2016 · 15 comments

Comments

@Spontifixus
Copy link

I find myself typing some URLs in config files or code constants, basically something like

String url = "http://www.example.com";

Same goes for things like variable names:

Url wwwUrl = new Url(...);

The www gets ligated to a zigzag-line here. I personally would prefer these three letters not to be concatenated but instead treated as three separate letters. Because as you stated in your readme.md:

For the human brain, sequences like ->, <= or := are single logical tokens, even if they take two or three characters on the screen

In my opinion www is no such token, but rather a concatenation of three letters, that can occur in comments, strings, variable names or wherever. This is basically the same as http, https, ftp, or mailto, which do not get ligated either.

What do you think?

@alexisvl
Copy link

The www token honestly looks bad. Out of all the ligatures in this font, most of which I like, www is the only one that I think sticks out like a gratuitous sore thumb. It feels like a slippery slope to having a ligature for everything in /usr/share/dict/words ;)

@krux02
Copy link

krux02 commented Aug 28, 2016

I think the fact that www is "a concatenation of three letters, that can occur in comments, strings, variable names or wherever" alone does not disqualify it for a ligature. just think of the very common ligatures fi ft etc in other normal fonts. But I do agree that the ligature chosen for www does not improve readability, and I heavily doubt that there might be a suitable ligature that would be suitable.

@FredrikAugust
Copy link

Completely agree, I don't think www should be made one symbol as it doesn't really increase the readability of your code.

@oderwat
Copy link

oderwat commented Aug 30, 2016

And www does not even really mean anything important. It is just the most common subdomain for no reason at all :) Please remove www ligature!

@cciotti
Copy link

cciotti commented Aug 30, 2016

It needs some refinement for sure. The x-height is too small for one and the spacing to the . could be closer. That said, I don't think it's a bad addition.

@kosiakk
Copy link

kosiakk commented Sep 7, 2016

www is there for fun and lulz.
Monoid has ligature for ¯\_(ツ)_/¯ for exactly the same reason :-)

@FredrikAugust
Copy link

To me that doesn't seem logical. www is something you use quite often, and you want that to be easily readable. The ascii-art isn't something you type regularly in your code, and therefore it isn't a problem if that is ligated.

If you want a joke in your font please use a string people don't use on a regular basis.

@alexisvl
Copy link

Come on, that's just bad. :D

eww

I mean, I know it's for code, not IRC, but... ewww

@monkpit
Copy link

monkpit commented Oct 31, 2016

@tonsky will this be addressed anytime soon?

@tonsky
Copy link
Owner

tonsky commented Nov 1, 2016

Not really — I like www. But if I do stylistic sets eventually, or online font builder, there’ll definitely be an option to turn it off.

@joffrey-bion
Copy link

This also surprised me as these are 3 separate letters and I don't see the rationale behind merging them.

@tonsky
Copy link
Owner

tonsky commented May 31, 2017

@joffrey-bion do you see a rationale in merging f and i in fi? It’s one of the most common ligature out there

@joffrey-bion
Copy link

@tonsky I don't see one that fits, and I also don't think the "fi" ligature has its place in this specific font. Ligatures are usually used in fonts when the handwritten version can be seen already (either by mistake or on purpose), which would justify both "www" and "fi".
My point is, I don't think this kind of ligature has its place in fira code, because I believe this font is not about making stuff look like handwritten, but rather about "tokenizing" combinations of characters often seen in programming, like arrows and comparators, to smooth the reading flow.

@tonsky
Copy link
Owner

tonsky commented Nov 19, 2018

Well I like it. It’s also a distinguishing feature. If I ever build a builder, there’ll definitely be an option to turn this off

@joffrey-bion
Copy link

joffrey-bion commented Nov 19, 2018

Fair enough, you're free to keep what you like, after all :)
It didn't really bother me for the past year, and I really enjoy the rest of the font, so I can live with that.

Losangelosgenetics pushed a commit to Losangelosgenetics/FiraCode that referenced this issue Mar 12, 2020
253: Add config to ignore Gemfile source r=bronzdoc a=ericzpd

This PR adds `:ignore_gemfile_source` config to ignore source specified in Gemfile and always use `:rubygems_url` as gems upstream.

Valid config values: `true` or `false`.

This change allows Gemstash to use a Bundler mirror site for fetching remote gems, instead of fetching from Gemfile source. 

Related Issue: tonsky#252 

Co-authored-by: Zheng Piaodan <zhengpiaodan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants