-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is ligating www to a zigzag-line a good idea? #253
Comments
The www token honestly looks bad. Out of all the ligatures in this font, most of which I like, www is the only one that I think sticks out like a gratuitous sore thumb. It feels like a slippery slope to having a ligature for everything in /usr/share/dict/words ;) |
I think the fact that www is "a concatenation of three letters, that can occur in comments, strings, variable names or wherever" alone does not disqualify it for a ligature. just think of the very common ligatures |
Completely agree, I don't think www should be made one symbol as it doesn't really increase the readability of your code. |
And www does not even really mean anything important. It is just the most common subdomain for no reason at all :) Please remove www ligature! |
It needs some refinement for sure. The x-height is too small for one and the spacing to the . could be closer. That said, I don't think it's a bad addition. |
|
To me that doesn't seem logical. If you want a joke in your font please use a string people don't use on a regular basis. |
@tonsky will this be addressed anytime soon? |
Not really — I like |
This also surprised me as these are 3 separate letters and I don't see the rationale behind merging them. |
@joffrey-bion do you see a rationale in merging |
@tonsky I don't see one that fits, and I also don't think the "fi" ligature has its place in this specific font. Ligatures are usually used in fonts when the handwritten version can be seen already (either by mistake or on purpose), which would justify both "www" and "fi". |
Well I like it. It’s also a distinguishing feature. If I ever build a builder, there’ll definitely be an option to turn this off |
Fair enough, you're free to keep what you like, after all :) |
253: Add config to ignore Gemfile source r=bronzdoc a=ericzpd This PR adds `:ignore_gemfile_source` config to ignore source specified in Gemfile and always use `:rubygems_url` as gems upstream. Valid config values: `true` or `false`. This change allows Gemstash to use a Bundler mirror site for fetching remote gems, instead of fetching from Gemfile source. Related Issue: tonsky#252 Co-authored-by: Zheng Piaodan <zhengpiaodan@gmail.com>
I find myself typing some URLs in config files or code constants, basically something like
String url = "http://www.example.com";
Same goes for things like variable names:
Url wwwUrl = new Url(...);
The www gets ligated to a zigzag-line here. I personally would prefer these three letters not to be concatenated but instead treated as three separate letters. Because as you stated in your readme.md:
In my opinion
www
is no such token, but rather a concatenation of three letters, that can occur in comments, strings, variable names or wherever. This is basically the same ashttp
,https
,ftp
, ormailto
, which do not get ligated either.What do you think?
The text was updated successfully, but these errors were encountered: