-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compiler conversions #171
Merged
Merged
Compiler conversions #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes across multiple files to improve exception handling, add new test cases, and update type conversion methods. The most important changes include adding exception handling for Python conversions, adding new test cases for collections and dictionaries, and updating type conversion methods to enhance functionality and reliability.
Exception Handling Improvements:
src/CSnakes.Runtime/CPython/Dict.cs
,src/CSnakes.Runtime/CPython/Import.cs
,src/CSnakes.Runtime/CPython/List.cs
,src/CSnakes.Runtime/CPython/Object.cs
,src/CSnakes.Runtime/CPython/Tuple.cs
,src/CSnakes.Runtime/CPython/Unicode.cs
) [1] [2] [3] [4] [5] [6]Test Case Additions:
PyObjectTests
for collections and dictionaries, ensuring the new conversion methods work as expected. (src/CSnakes.Runtime.Tests/Python/PyObjectTests.cs
)Type Conversion Enhancements:
PyObjectTypeConverter
to improve type conversion methods, including adding new methods for converting to collections and dictionaries. (src/CSnakes.Runtime/PyObjectTypeConverter.Dictionary.cs
,src/CSnakes.Runtime/PyObjectTypeConverter.List.cs
,src/CSnakes.Runtime/PyObjectTypeConverter.Generator.cs
,src/CSnakes.Runtime/PyObjectTypeConverter.BigInteger.cs
) [1] [2] [3] [4] [5]Code Formatting:
src/CSnakes.Runtime.Tests/RuntimeTestBase.cs
,src/CSnakes.Runtime.Tests/Python/PyObjectTests.cs
) [1] [2]Internal Method Updates:
PyObjectTypeConverter
to internal, allowing for better encapsulation and testing. (src/CSnakes.Runtime/PyObjectTypeConverter.Dictionary.cs
,src/CSnakes.Runtime/PyObjectTypeConverter.Generator.cs
,src/CSnakes.Runtime/PyObjectTypeConverter.BigInteger.cs
) [1] [2] [3]