Refactor PythonConstant
types into a true union
#234
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to refactor
PythonConstant
types into a true union via a class hierarchy wherePythonConstant
becomes an abstract base class and the various types its nested subclasses. This has the following benefits:ToString
instead of a switch-case.Value
onPythonConstant.Integer
is typed aslong
whereasValue
onPythonConstant.String
is typed asstring
.Bool
andNone
have statically initialised values, which avoids unnecessary allocations.PythonConstant.ConstantType
is no longer needed.ArgumentReflection.ArgumentSyntax
).