Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minimist version #304

Merged
merged 3 commits into from
Mar 30, 2020
Merged

Update minimist version #304

merged 3 commits into from
Mar 30, 2020

Conversation

guoyunhe
Copy link
Contributor

@watson
Copy link

watson commented Mar 16, 2020

This should really be ^1.2.5 as a few other security issues were fixed in later versions

@guoyunhe
Copy link
Contributor Author

Updated to ^1.2.5

@theogravity
Copy link

@tonyganch could you look at this PR?

@XhmikosR XhmikosR mentioned this pull request Mar 18, 2020
Closed
@yhatt yhatt mentioned this pull request Mar 18, 2020
Merged
@shaundr
Copy link

shaundr commented Mar 18, 2020

What are we waiting on?

@legoktm legoktm mentioned this pull request Mar 20, 2020
Closed
@jamestharpe
Copy link

Looks like some updates may need to be made to the CI process as well: https://travis-ci.org/github/tonyganch/gonzales-pe/jobs/663227249?utm_medium=notification&utm_source=github_status

@tonyganch tonyganch merged commit 3c19aca into tonyganch:dev Mar 30, 2020
@guoyunhe guoyunhe mentioned this pull request Mar 30, 2020
Merged
@sojeri sojeri mentioned this pull request Apr 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@guoyunhe @watson @theogravity @shaundr @jamestharpe @tonyganch