Skip to content

Commit

Permalink
Do not initiate MMP writes while pool is suspended
Browse files Browse the repository at this point in the history
While the pool is suspended on host A, it may be imported on host B.
If host A continued to write MMP blocks, it would be blindly
overwriting MMP blocks written by host B, and the blocks written by
host A would have outdated txg information.

Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Olaf Faaland <faaland1@llnl.gov>
Closes openzfs#7182
  • Loading branch information
ofaaland authored and tonyhutter committed Mar 6, 2018
1 parent 074cffe commit f471fb5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion module/zfs/mmp.c
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ mmp_thread(spa_t *spa)
zio_suspend(spa, NULL);
}

if (multihost)
if (multihost && !suspended)
mmp_write_uberblock(spa);

CALLB_CPR_SAFE_BEGIN(&cpr);
Expand Down

0 comments on commit f471fb5

Please sign in to comment.