Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Cannot find module '@ngx-tonysamperi/dom' #26

Closed
habtim opened this issue Jun 28, 2022 · 3 comments
Closed

BUG: Cannot find module '@ngx-tonysamperi/dom' #26

habtim opened this issue Jun 28, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@habtim
Copy link

habtim commented Jun 28, 2022

Describe the bug
When using this library, by npm install @popperjs/core ngx-popperjs --save, @ngx-tonysamperi/dom is not installed as it is not marked as a peer dependency.
Therefore, I get an error when consuming NgxPopperjsModule:

Cannot find module '@ngx-tonysamperi/dom' from '../../../../node_modules/ngx-popperjs/fesm2020/ngx-popperjs.mjs'

Workaround:
Can be solved by running npm i @ngx-tonysamperi/dom --save

To Reproduce

  • Run npm install @popperjs/core ngx-popperjs --save
  • Either:
    • Check node_modules: No @ngx-tonysamperi/dom available
    • Consume NgxPopperjsModule anywhere in your app

Expected behavior
ngx-tonysamperi/dom should be installed as dependency as well when running npm install @popperjs/core ngx-popperjs --save

Versions

  • ngx-popperjs [14.0.0]
  • @angular/core version [14.0.3]
  • @angular/material version [14.0.3]
  • typescript version [4.7.4]

Additional context
Seems like I'm the only one with this issue, maybe there is something that I'm missing?

@tonysamperi tonysamperi added the invalid This doesn't seem right label Jun 28, 2022
@tonysamperi
Copy link
Owner

tonysamperi commented Jun 28, 2022

Before dom there was smp-core-utils and it's never been marked as dependency, or peer.

@tonysamperi
Copy link
Owner

Actually after a second though, smp-core-utils wasn't used, that's why it wasn't a peer. Ok, I'll patch it right away!

@tonysamperi tonysamperi reopened this Jun 28, 2022
tonysamperi added a commit that referenced this issue Jun 28, 2022
* Added missing peer dep (closes [#26](#26))
@tonysamperi
Copy link
Owner

@habtim

I moved @ngx-tonysamperi/dom and @popperjs/core to dependencies, so that installing ngx-popperjs will automatically get everything!

v 13.3.0

@tonysamperi tonysamperi added enhancement New feature or request and removed invalid This doesn't seem right labels Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants