Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework TBui.tbRedditEvent to be viewport aware. #255

Closed
creesch opened this issue Mar 10, 2020 · 0 comments
Closed

Rework TBui.tbRedditEvent to be viewport aware. #255

creesch opened this issue Mar 10, 2020 · 0 comments
Assignees
@creesch
Labels
code quality core: tbui
Milestone
v5.3

Comments

@creesch
Copy link
Member

creesch commented Mar 10, 2020

Currently it isn't but it should use a viewport observer similar to how the old reddit module does.
@creesch creesch self-assigned this Mar 10, 2020
creesch added a commit that referenced this issue Mar 10, 2020
@creesch
Make TBui.tbRedditEvent viewport aware fixes #255
a39af96
@eritbh eritbh added this to the v5.3 milestone Mar 22, 2020
eritbh pushed a commit that referenced this issue Sep 5, 2024
@creesch
Make TBui.tbRedditEvent viewport aware fixes #255 (#256)
a705022 
* Make TBui.tbRedditEvent viewport aware fixes #255

* remove unneeded parameters

* Dangit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@creesch creesch

Labels
code quality core: tbui
Projects
None yet
Milestone
v5.3
Development

No branches or pull requests
2 participants
@creesch @eritbh