Background page structuring #171

eritbh · 2019-10-14T03:32:43Z

Fixes #129, partially addresses #44.

TODOs:

Split up various concerns in the background page to their own files for organization
Rework message format from {action: 'thing', ...options} to ['thing', {options}] to free up the action key for use in handlers
Rename message actions to not use the tb- prefix and use a more descriptive convention (needs discussion)
chrome.* -> browser.* webextension APIs

eslint complained about not using `await` and we don't want to return promises if we have no response.

Venefilyn

I've not looked at the differences between background and the new handlers, would've been nicer if the split was done first and then changes made so we can more easily see what's changing

extension/data/background/handlers/cache.js

extension/data/background/handlers/notifications.js

extension/data/background/handlers/webrequest.js

creesch

Left some comments. I mostly had a general look so far as I understand that this is pretty much a work in progress.

.eslintrc.json

extension/data/background/background.js

extension/data/background/handlers/globalmessage.js

extension/data/background/handlers/notifications.js

extension/data/background/handlers/webrequest.js

extension/manifest.json

Co-Authored-By: Eric <SpyTec@users.noreply.github.com>

* Add webextension-polyfill@0.5.0 (background only) * Convert message listener to browser API + promises * Add basic message handler logic * Add no-return-await to eslint * Use explicit promise returns in message listener eslint complained about not using `await` and we don't want to return promises if we have no response. * Split out web request handler * Split out reload handler * Split out cache/global, use right polyfill file * Split out notification handling * chrome -> browser for most of the background stuff * Can't be clever about this one... * ? isn't a thing in jsdoc Co-Authored-By: Eric <SpyTec@users.noreply.github.com> * Directory eslint to remove per-file comments * Un-minify webext-polyfill * Handle background-bound global events more cleanly * Apply changes from master, misc. cleanup * Remove invalid jsdoc tag

eritbh added 10 commits October 13, 2019 21:26

Add webextension-polyfill@0.5.0 (background only)

6d2cbf3

Convert message listener to browser API + promises

efc7374

Add basic message handler logic

91555b9

Add no-return-await to eslint

23726b8

Use explicit promise returns in message listener

fd92b8a

eslint complained about not using `await` and we don't want to return promises if we have no response.

Split out web request handler

341e109

Split out reload handler

3f1efad

Split out cache/global, use right polyfill file

3267ca7

Split out notification handling

3e4795f

chrome -> browser for most of the background stuff

3a1bc20

eritbh added core: background code quality labels Oct 14, 2019

eritbh added this to the v5.3 milestone Oct 14, 2019

eritbh requested a review from creesch October 14, 2019 03:32

eritbh self-assigned this Oct 14, 2019

Can't be clever about this one...

40de52d

Venefilyn reviewed Oct 14, 2019

View reviewed changes

creesch reviewed Oct 14, 2019

View reviewed changes

eritbh and others added 6 commits October 19, 2019 08:13

? isn't a thing in jsdoc

e17c9e6

Co-Authored-By: Eric <SpyTec@users.noreply.github.com>

Directory eslint to remove per-file comments

f498bbd

Un-minify webext-polyfill

da2ba5a

Handle background-bound global events more cleanly

2dc1fa0

Apply changes from master, misc. cleanup

0325dc1

Remove invalid jsdoc tag

665f782

eritbh marked this pull request as ready for review October 21, 2019 00:22

Merge branch 'master' into background-organization

0d091c0

eritbh merged commit 434ec0b into master Oct 21, 2019

eritbh deleted the background-organization branch October 21, 2019 17:04

eritbh modified the milestones: v5.x, v5.3 Mar 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Background page structuring #171

Background page structuring #171

eritbh commented Oct 14, 2019 •

edited

Loading

Venefilyn left a comment

creesch left a comment

Background page structuring #171

Background page structuring #171

Conversation

eritbh commented Oct 14, 2019 • edited Loading

Venefilyn left a comment

Choose a reason for hiding this comment

creesch left a comment

Choose a reason for hiding this comment

eritbh commented Oct 14, 2019 •

edited

Loading