Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert more stuff to use TBLog #197

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Convert more stuff to use TBLog #197

merged 1 commit into from
Nov 22, 2019

Conversation

eritbh
Copy link
Member

@eritbh eritbh commented Nov 20, 2019

Replaces console.* calls in most of the extension with calls to TBLog methods. tbmigrate.js still needs to be handled, but I don't know if the profiling function in there right now needs to be redone or not.

@eritbh eritbh added enhancement New feature or request code quality labels Nov 20, 2019
@creesch
Copy link
Member

creesch commented Nov 22, 2019

Looks good to me, I assume this is ready to merge?

@Venefilyn
Copy link
Member

LGTM

@eritbh eritbh merged commit 2c2b798 into master Nov 22, 2019
@eritbh eritbh deleted the more-tblog-less-console branch January 29, 2020 22:19
@eritbh eritbh added this to the v5.3 milestone Mar 10, 2020
eritbh added a commit that referenced this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants