Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UserNotes): Wrap on resize #235

Merged
merged 3 commits into from
Feb 27, 2020
Merged

fix(UserNotes): Wrap on resize #235

merged 3 commits into from
Feb 27, 2020

Conversation

Venefilyn
Copy link
Member

@Venefilyn Venefilyn commented Feb 25, 2020 •
edited
Loading

Fixes #216
This now uses flexbox and goes to new line when box is too small

@Venefilyn Venefilyn added enhancement New feature or request module: usernotes labels Feb 25, 2020
@eritbh
Copy link
Member

eritbh commented Feb 27, 2020

Since this isn't a table anymore and borders between items no longer collapse into each other, could we put like a 2px margin-left and margin-bottom on each note type to make it look a bit cleaner?

Before:
image

After:
image

creesch
creesch requested changes Feb 27, 2020
View reviewed changes
Copy link
Member

@creesch creesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

You forgot a few css things that breaks selecting of a type, also had a few other minor things.

extension/data/styles/usernotes.css Outdated Show resolved Hide resolved
extension/data/styles/usernotes.css Outdated Show resolved Hide resolved
extension/data/styles/usernotes.css Outdated Show resolved Hide resolved
extension/data/styles/usernotes.css Outdated Show resolved Hide resolved
Eric and others added 2 commits February 27, 2020 10:38
@creesch
Update extension/data/styles/usernotes.css
77bb60e 
Co-Authored-By: creesch <creesch@users.noreply.github.com>
style(UserNotes): Fixed transition and wildcard
e16396c
@Venefilyn Venefilyn requested a review from creesch February 27, 2020 09:45
@creesch creesch merged commit b670515 into master Feb 27, 2020
@eritbh eritbh deleted the fix/usernotes-resize branch March 2, 2020 21:00
@eritbh eritbh added this to the v5.3 milestone Mar 10, 2020
eritbh pushed a commit that referenced this pull request Sep 5, 2024
fix(UserNotes): Wrap on resize (#235)
d575df6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creesch creesch creesch approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request module: usernotes
Projects
None yet
Milestone
v5.3
Development

Successfully merging this pull request may close these issues.

User note type display gets messy with lots of types or small windows
3 participants
@Venefilyn @eritbh @creesch