Misc. code cleanup stuff (#243) (rip isOdd) #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creesch
reviewed
Mar 9, 2020
| @@ -551,17 +550,6 @@ function modbutton () { | |||
| } | |||
| } | |||
|
|
|||
| function createBanReason (message) { | |||
There was a problem hiding this comment.
I have no idea, lol. In its current state it was just a fancy way of returning the same string, so I removed it. Not sure if there was originally other functionality attached that was removed, or if someone had plans to make fancier ban reasons or something like that.
eritbh
changed the title
eritbh
added a commit
that referenced
this pull request
Sep 5, 2024
* Nuke useless ban message logic * Helper methods for making RegExps from user input * Don't pass RegExp literals to new RegExp() * Remove single-use helper TBHelpers.isOdd() * Add comments and stuff to other helper methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation to a lot of helper methods, removes useless logic and unused functions, and other stuff like that. No particular priority, I'll be adding to this branch as I go through other code quality issues.