Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently
no-shadow
isn't part ofeslint:recommended
. It should be, but that's not up to me.This adds
no-shadow
to our config. This rule reports an error whenever a variable name from an upper scope is reused in a lower scope. This prevents uncertainty in which identically-named variable is actually being referenced in code.builtinGlobals
ensures that we aren't shadowing the names of built-in objects, andhoist: all
makes the following invalid: