Fix okOnly requests and correctly handle errors when editing AutoModerator configuration
#361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eritbh
added a commit
that referenced
this pull request
Sep 9, 2020
…derator configuration (#361) * Normalize throws in background makeRequest * update content script sendRequest error handling * update automod popup error handling for fetch
eritbh
added a commit
that referenced
this pull request
Sep 5, 2024
…derator configuration (#361) * Normalize throws in background makeRequest * update content script sendRequest error handling * update automod popup error handling for fetch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complicated problem, described in Discord: https://discordapp.com/channels/535490452066009090/535490561478492161/751486540739379332
This PR ensures that errors are handled consistently by the background page and passed in a consistent format to the content script. It also reworks error handling in the config module's AutoModerator editor to properly report errors when saving the page.