NewModMailPro: Fix message sending errors on FF #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without including `cancelable: false`, Firefox will invoke the normal form submission logic for the form. Since React manages the content of the fields, it ends up submitting an empty message, which reddit doesn't like.
eritbh
added a commit
that referenced
this pull request
Oct 6, 2020
eritbh
pushed a commit
that referenced
this pull request
Sep 5, 2024
Without including `cancelable: false`, Firefox will invoke the normal form submission logic for the form. Since React manages the content of the fields, it ends up submitting an empty message, which reddit doesn't like.
eritbh
added a commit
that referenced
this pull request
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without including
cancelable: false, Firefox will invoke the normal form submission logic for the form. Since React manages the content of the fields, it ends up submitting an empty message, which reddit doesn't like.This solution works on both FF and Chrome. A mod of mine has been testing it for a few days now and has not encountered any issues yet.