Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selectors for "Send Modmail" modbutton tab #391

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

eritbh
Copy link
Member

@eritbh eritbh commented Oct 8, 2020

Fixes #390. The selectors for input elements in this tab included .send_message, which was a class that TBui.popup() generated from the title of the tab. Changing the tab's title in #369 inadvertently changed this class and broke links to the UI elements.

@eritbh eritbh added bug something isn't working module: modbutton labels Oct 8, 2020
@creesch creesch merged commit 9226b24 into master Oct 8, 2020
@creesch creesch deleted the fix-modbutton-input-selectors branch October 8, 2020 08:10
@eritbh eritbh added this to the v5.4.3 milestone Oct 19, 2020
eritbh added a commit that referenced this pull request Sep 5, 2024
* Fix selectors for "Send Modmail" modbutton tab

* derp, don't include console.log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working module: modbutton
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sending modmail through modbutton does not work.
3 participants