Improve request interface #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any particular reason this isn't merged? Or is it just awaiting review? In any case lgtm. |
|
Waiting for review, and like most of my open PRs I wanted to land them after we're done with 5.5.x releases - but we seem to keep needing more bug fix releases :P |
eritbh
added a commit
that referenced
this pull request
Sep 5, 2024
* Update doc comment for serializeResponse * Simplify code for response message generation * Support sending arbitrary string bodies * Simplify body type check to make deepscan happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for passing plain string bodies for POST requests, rather than always interpreting
options.bodyas form data. This clears the way for features using new APIs that use JSON bodies rather than form data, such as #448. Also simplifies the code used to send messages from the background page back to the content script when a request has finished, and corrects some documentation comments.