Replace old Module.setting() calls and clean up some other setting access #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eritbh
changed the title
eritbh
added a commit
that referenced
this pull request
Sep 5, 2024
…cess (#600) * Replace old Module.setting() calls * Remove unused import from betterbuttons * Don't do weird module lookup to get settings * Convert some more storage calls to async variants * that's not how this method works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a reported issue where Toolbox wouldn't save the last settings backup date when backing up settings because the method used to do that no longer exists. https://www.reddit.com/r/toolbox/comments/wwtavx/doesnt_think_ive_backed_up/
Also cleans up some storage access stuff; moves some calls to the async variants introduced in #518, and replaces some weird calls that looked up the module by shortname and called
.get()/.set(); they now useTBStoragemethods directly, as discussed on Discord: https://discord.com/channels/535490452066009090/535490561478492161/1012093614903545866