Fix for faulty reddit color-scheme implementation #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eritbh
requested changes
Sep 30, 2022
extension/data/styles/toolbox.css
Outdated
| } | ||
|
|
||
| body.mod-toolbox-rd.mod-toolbox-extra .tb-input:focus-visible, |
There was a problem hiding this comment.
:focus-visible implies :focus, so this added selector is redundant and should change nothing; if the goal is to get :focus-visible behavior then the :focus option should be removed
eritbh
approved these changes
Sep 30, 2022
eritbh
pushed a commit
that referenced
this pull request
Sep 5, 2024
* Fix for faulty reddit color-scheme implementation * fix review comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically reddit implemented color-scheme to
:rootin a very weird way that basically ignores it. Turns out that we didn't explicitly did style some elements text color which then turned white and a few default html elements turned dark.This PR makes toolbox's css more explicit and also disables any color-scheme for anything within tb-window popups or overlays.