Timeago helper function #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashen-dawn
approved these changes
Jul 4, 2023
| export function relativeTime (date) { | ||
| // create element | ||
| const el = document.createElement('time'); | ||
| el.dateTime = date.toISOString(); |
There was a problem hiding this comment.
So just to make sure we know what's going on here - putting the dateTime property on an element allows you to use the .timeago() jquery thing?
There was a problem hiding this comment.
Yeah, that's correct. timeago is a plugin from npm; it's not directly obvious where we load it from, but you can read more about it here: https://www.npmjs.com/package/timeago
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a helper function
TBui.relativeTime()which creates<time>elements that are automatically rendered as relative times, without UI code being required to manually invoketimeago. This should help avoid issues like #777 in the future.timeagoneeds to be run once the target element is already in the DOM, so this implementation keeps track of the elements the helper function has created and uses aMutationObserverto calltimeagoautomatically once they are in the DOM. This is especially helpful for the submission/comment UI builder functions, which until now required consuming code to manually$result.find('time').timeago()after the result was added to the DOM.