-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TS conversion starting point #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashen-dawn
approved these changes
Jul 14, 2023
this is where the fun begins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts the first set of stuff to Typescript for #761. Everything still builds, yay!
Note the
compilerOptions.outDir
hack intsconfig.json
-@rollup/plugin-typescript
ignores all output options and does its own thing to pull the build output into the rollup bundle, and it will also just let you pass the tsconfig structure directly to the plugin instead of reading from a file, so it's not strictly necessary to have atsconfig.json
in the first place. However a lot of tooling relies on having atsconfig.json
to know what's going on, so I decided to just pointoutDir
to a throwaway directory inbuild
.tsc
the project, which you should never need to do since rollup will choke on TS errors thanks tonoEmitOnError
. Might be useful at some point in the future for debugging more arcane errors or emergent issues in rollup/its TS plugin though.There is no linting for TS files because I don't feel like duplicating our entire linter config into
typescript-eslint
rules at the moment -this should get done before this PR gets merged thoughthis will be handled in a separate issue Rework project formatting #784 because the ecosystem has changed significantlytoolbox-devvit
JS and TS files have different conventions for how file extensions on imports work:
I've opted to change as little as possible to get the build to work; eventually everything will be Typescript files importing other Typescript files anyway, at which point every import will be extensionless.