-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style tweaks for controls in window footers #807
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The styles look good in testing, a few questions about your CSS selectors, but either way I'm approving it.
justify-content: center; | ||
align-items: center; | ||
background-color: #CEE3F8; | ||
} | ||
/* A form can be the only child of the footer - use it as the flex container */ | ||
.mod-toolbox-rd .tb-window-footer > form { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this rule is specifically for the form being the only child, we may want to do
.mod-toolbox-rd .tb-window-footer > form { | |
.mod-toolbox-rd .tb-window-footer > form:only-child { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is really necessary tbh - there's no case where a form
has
siblings in a footer, and I can't think of a reason we'd need to do that in the
future either. Plus, since these rules set the gap
and other flex layout stuff
consistently between the form
and the footer itself, I think this should work
pretty much as-is in the case where there is a form
with arbitrary siblings,
so there's no need to arbitrarily lock this down.
Examples of the new styles: