Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we update and regularly rebuild the images or not? #5

Open
travier opened this issue Sep 3, 2022 · 15 comments
Open

Should we update and regularly rebuild the images or not? #5

travier opened this issue Sep 3, 2022 · 15 comments
Labels
enhancement Improvement to existing images

Comments

@travier
Copy link
Member

travier commented Sep 3, 2022

Right now, the Containerfiles do not update the packages in the image.

We have two options:

  • Keep the Containerfiles as is (users will update them on first run anyway) and remove all weekly rebuilds as they won't change the image.
  • Update the Containerfiles to make sure that they update the packages and trigger rebuilds every two weeks (weekly seems to much).

Note: This discussion apply to Arch Linux too but we need to keep it updated monthly at miminum.

@Foxboron
Copy link
Contributor

Foxboron commented Sep 3, 2022

I'd perfer weekly rebuilds for Arch as we are dealing with work containers.

@travier
Copy link
Member Author

travier commented Sep 3, 2022

Any particular reason for weekly rebuilds? Do you re-create one every week? Then if that's the case do you re-install all your tools there every time? Then I'd say that maybe you're better served by having your own container build from another repo on top of this one. I have mine in https://github.com/travier/quay-containerfiles/tree/main/toolbox for example that builds on top of the Fedora one.

I would say that the target for those images is people that create an image and update it over time instead of re-creating it all the time.

@Foxboron
Copy link
Contributor

Foxboron commented Sep 3, 2022

Packages update fast in Arch. If you create a new container at the tailend of the month then a lot of those packages are going to be old. It's better to use toolbox create and know the container isn't super outdated.

@travier
Copy link
Member Author

travier commented Sep 3, 2022

OK, let's do weekly rebuilt. I hope we'll have enough built minutes.

@travier travier added the need-info Further information is requested label Sep 9, 2022
@HarryMichal
Copy link

The same reasoning for periodical rebuilds can also apply to Fedora Rawhide.

@travier
Copy link
Member Author

travier commented Sep 13, 2022

Agree that Rawhide should be rebuilt regularly. Is this not the case right now?

@travier
Copy link
Member Author

travier commented Sep 13, 2022

Note that most of the images here do not update the packages. I'm looking at that in #20.

@travier
Copy link
Member Author

travier commented Sep 13, 2022

Looks like I read https://docs.github.com/en/billing/managing-billing-for-github-actions/about-billing-for-github-actions incorrectly and actions minutes are free and unlimited for public projects. I will turn builds on in PRs.

@HarryMichal
Copy link

Agree that Rawhide should be rebuilt regularly. Is this not the case right now?

All Fedora Toolbx images are being rebuilt regularly. I mainly mentioned it to support the need for Arch Linux images to be rebuilt regularly.

@Jmennius
Copy link
Contributor

I think Ubuntu images should be rebuilt bi-weekly but at least once a month.

@travier
Copy link
Member Author

travier commented Sep 19, 2022

Then they need some work like I did in 52a51d5 for the CentOS ones as right now they don't update at all.

@travier
Copy link
Member Author

travier commented Sep 19, 2022

Well, they do get updated but only if the base image is updated.

travier added a commit that referenced this issue Sep 19, 2022
Make sure to not re-use cached layers to always fully update the image
every time we rebuilt it.

See: #5
@travier travier added enhancement Improvement to existing images and removed need-info Further information is requested labels Oct 11, 2022
travier added a commit that referenced this issue Oct 19, 2022
@travier
Copy link
Member Author

travier commented Oct 19, 2022

#41 should close this one.

@travier
Copy link
Member Author

travier commented Oct 20, 2022

See discussion in #41, we'll not update Debian & Ubuntu images.
Maybe we revisit the discussion here and not update all images by default.

@debarshiray
Copy link
Contributor

Agree that Rawhide should be rebuilt regularly. Is this not the case right now?

All Fedora Toolbx images are being rebuilt regularly. I mainly mentioned it to support the need for Arch Linux images to be rebuilt regularly.

Just to be clear ...

These days, since the Fedora 39 development cycle, the fedora-toolbox image for Rawhide gets built as part of the nightly composes. Earlier, they were being manually rebuilt every few weeks, just like the images for the stable Fedora releases.

Currently, the built-in arch-toolbox and ubuntu-toolbox images, maintained as part of Toolbx, are rebuilt every Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing images
Development

No branches or pull requests

5 participants