Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ubuntu: Add libcap2-bin for capsh #74

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

travier
Copy link
Member

@travier travier commented Mar 16, 2023

Fixes: #73

@Jmennius
Copy link
Contributor

Should we put it into the container file itself since it is essential to the image (not just extra)?

@travier
Copy link
Member Author

travier commented Mar 16, 2023

This file is used during the container build to include the package in the container.

@travier
Copy link
Member Author

travier commented Mar 16, 2023

Copy link
Contributor

@debarshiray debarshiray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, this fixes #73 for me.

@Jmennius
Copy link
Contributor

This file is used during the container build to include the package in the container.

What I mean is - add it directly to the Containerfile - same install command but explicitly on the command line there.
Because packages listed in extra-packages are supposed to be 'extra' as the name suggests (i.e. optional) and one can expect to clean this file and the image to still be functional (which it won't be, without capsh).

@travier
Copy link
Member Author

travier commented Mar 17, 2023

We don't split between "mandatory" and "extra" packages as far as I know.

@travier
Copy link
Member Author

travier commented Mar 17, 2023

Feel free to make a PR to create that split :)

@travier travier changed the title ubuntu/18.04: Add libcap2-bin for capsh ubuntu: Add libcap2-bin for capsh Mar 17, 2023
@travier travier merged commit f8963b3 into toolbx-images:main Mar 17, 2023
@travier travier deleted the ubuntu1804-capsh branch March 17, 2023 17:03
@Jmennius
Copy link
Contributor

We don't split between "mandatory" and "extra" packages as far as I know.

I consider whatever we install in the Containerfile to be required for the image to function, by this logic - there is a split already :) For example, ubuntu-minimal, ubuntu-standard and libnss-myhostname installed there are mandatory.

@Jmennius
Copy link
Contributor

Opened #75 which reverts this partially (not the sort).

@debarshiray
Copy link
Contributor

debarshiray commented Mar 20, 2023

For example, ubuntu-minimal, ubuntu-standard and libnss-myhostname installed there are mandatory.

The Git history says that /usr/local/sbin/unminimize, ubuntu-minimal and ubuntu-standard were removed from ubuntu-toolbox:18.04 in commit 5cbaecde2f30ea1d to fix the build.

@Jmennius
Copy link
Contributor

For example, ubuntu-minimal, ubuntu-standard and libnss-myhostname installed there are mandatory.

The Git history says that /usr/local/sbin/unminimize, ubuntu-minimal and ubuntu-standard were removed from ubuntu-toolbox:18.04 in commit 5cbaecde2f30ea1d to fix the build.

I'm curious what happened there.. but it has worked before that and it works now (unminimizing and installing ubuntu-minimal and ubuntu-standard metapackages; plus other container are just like this). Hopefully it was just an intermittent failure...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

New Package: libcap2-bin - Ubuntu 18.04
3 participants