Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic support for plotting preshaped qcodes data directly #148

Conversation

jenshnielsen
Copy link
Collaborator

This will require microsoft/Qcodes#2264 and qcodes 0.20.0 release to actually work

@jenshnielsen jenshnielsen force-pushed the better_use_of_qcodes_cache branch from df8ad9d to 209ac5a Compare November 4, 2020 09:10
Copy link
Collaborator

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is good :) it was tough to review though because even though the changes are minimal, it does take time to understand what happens where and when and where shape is actually used, etc. :)

@astafan8
Copy link
Collaborator

astafan8 commented Nov 6, 2020

it seems to me that datadict_to_meshgrid could use some optimization/improvement so that it does not recreate arrays if existing shape is to be used. but i don't know if i'm even correct. and it's definitely not for this PR.

@jenshnielsen jenshnielsen merged commit 3d99990 into toolsforexperiments:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants