Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the AppManager. Still missing GUI. #325

Merged
merged 18 commits into from
Oct 24, 2022

Conversation

pfafflabatuiuc
Copy link
Contributor

Adding a new version of the AppManager, used to manage and communicate with apps running in different QProcesses. You can send messages to the apps to change the parameters that live inside of them.

For more information on how it works, check the correct docstrings.

The AppManager has been tested in linux and windows.

@marcosfrenkel
Copy link
Collaborator

I have added an issue to be close with this PR. Another 2 open issues that are related but I am not sure if they should be closed:

#205

#91 -> This one seems to be very similar to issue #228 but with extra features (like logging) Those are not yet implemented in the launching script. I have opened another issue to add logging and a way to see the messages the other app is showing. When opening an app from the script itself from terminal, you can see the messages it sends

@marcosfrenkel
Copy link
Collaborator

marcosfrenkel commented Sep 26, 2022

The mypy error is a known issue with python 3.10.7 and mypy. There is a solution coming but the work around is to downgrade to python 3.10.6 for now: python/mypy#13627

I don't know how (or even if I can) reconfigure the automatic testing to do that.

@jenshnielsen
Copy link
Collaborator

@marcosfrenkel mypy 0.981 is out and #331 will fix this

Copy link
Contributor

@wpfff wpfff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed in the lab -- looks good!

@wpfff wpfff merged commit af42b2f into toolsforexperiments:master Oct 24, 2022
@pfafflabatuiuc pfafflabatuiuc deleted the merging_appman branch October 24, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

launcher script that can be used to liveplot a single measurement without monitr
4 participants