Drop python 3.7 support and Typecheck with Pandas stubs #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
force-pushed
the
pandas_stubs
branch
from
663116d to
7abd631
Compare
|
Pandas 1.4 only supports python 3.8 and up. Perhaps we should drop support for 3.7 or just drop type checking with 3.7 ? |
vote for this |
|
@wpfff How do you feel about dropping support for 3.7 The main motivation is that Pandas, numpy, xarray etc have already dropped it making it more annoying to support it here. QCoDeS will drop support soon |
|
Yep, we should drop it. Haven't seen anything below 3.9 in use in a while myself... |
jenshnielsen
changed the title
|
@astafan8 Dropped python 3.7 and make it ready for review |
astafan8
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds pandas types and fixes two issues required to typecheck with them.
One is not potentially passing None to a method that does not take None
The other is a workaround for not being able to infer a precise type for a dataframe converted to dict