Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages from apps from the AppManager. #347

Merged
merged 7 commits into from
Nov 22, 2022

Conversation

pfafflabatuiuc
Copy link
Contributor

This PR fixes the issue #324 and adds a way of seeing messages from apps managed by the AppManager.

@pfafflabatuiuc
Copy link
Contributor Author

Discovered that the app was not closing properly after I was able to see the crash messages.

Only thing I am not sure if its ok, I am using a hidden variable in my code. However, in the documentation the variable is there: https://pyzmq.readthedocs.io/en/latest/api/zmq.html#zmq.Socket.closed

@marcosfrenkel marcosfrenkel linked an issue Nov 14, 2022 that may be closed by this pull request
Copy link
Contributor

@wpfff wpfff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@wpfff wpfff merged commit f877d2f into toolsforexperiments:master Nov 22, 2022
@pfafflabatuiuc pfafflabatuiuc deleted the messages_from_apps branch November 22, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have a way of having the errors of the app manager visible.
2 participants