Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some new things for datadict #391

Merged
merged 14 commits into from
May 23, 2023
Merged

some new things for datadict #391

merged 14 commits into from
May 23, 2023

Conversation

wpfff
Copy link
Contributor

@wpfff wpfff commented May 22, 2023

  • small fixes in making structures
  • get size of data
  • convenience methods

@wpfff wpfff requested a review from marcosfrenkel May 22, 2023 15:20
marcosfrenkel
marcosfrenkel approved these changes May 23, 2023
View reviewed changes
Copy link
Collaborator

@marcosfrenkel marcosfrenkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@wpfff wpfff merged commit 8727a6a into toolsforexperiments:master May 23, 2023
@wpfff wpfff deleted the feature/dd-methods branch May 23, 2023 14:53
@wpfff wpfff mentioned this pull request May 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosfrenkel marcosfrenkel marcosfrenkel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wpfff @marcosfrenkel