Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support msw v2 #128

Merged
merged 2 commits into from
Dec 27, 2023
Merged

chore: support msw v2 #128

merged 2 commits into from
Dec 27, 2023

Conversation

toomuchdesign
Copy link
Owner

What kind of change does this PR introduce?

Refactor

What is the current behaviour?

Only msw v1 supported

What is the new behaviour?

Only msw v2 supported

Does this PR introduce a breaking change?

Yes, due to the new msw v2 implementation, requestLogger and mswInspector.getRequests methods are now async.

Other information:

Please check if the PR fulfills these requirements:

  • Tests for the changes have been added
  • Docs have been added / updated

BREAKING CHANGE
mswInspector.getRequests returns a promise
Copy link

github-actions bot commented Dec 23, 2023

Pull Request Test Coverage Report for Build 7338786325

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 26 of 26 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 7296138306: 0.0%
Covered Lines: 51
Relevant Lines: 51

💛 - Coveralls

@toomuchdesign toomuchdesign merged commit 394905d into master Dec 27, 2023
2 checks passed
@toomuchdesign toomuchdesign deleted the msw-v2 branch December 27, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant