Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inplement request matching using regex #201

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

rickythefox
Copy link
Contributor

What kind of change does this PR introduce?

Implements #200

What is the current behaviour?

We can only match against url path and need to provide a hostname.

What is the new behaviour?

We can match against any part of the request url using a regular expression.

Does this PR introduce a breaking change?

No

Other information:

Please check if the PR fulfills these requirements:

  • Tests for the changes have been added
  • Docs have been added / updated

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8814510517

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 46 of 46 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8732290081: 0.0%
Covered Lines: 202
Relevant Lines: 202

💛 - Coveralls

@toomuchdesign toomuchdesign merged commit 6e3853b into toomuchdesign:master Apr 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants