Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handling in tootctl media remove-orphans #12571

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Dec 8, 2019

In S3 mode: If listing objects fails, output message with the appropriate --start-after argument to resume execution in the future. If deleting individual objects fails, log the error and move on.

In filesystem mode: If file size or delete fails, log the error and move on.

Do not increase totals before the deletion succeeds.

@Gargron Gargron force-pushed the fix-error-handling-media-remove-orphans branch from 2c9ae5a to dd406e2 Compare December 8, 2019 21:48
@Gargron Gargron force-pushed the fix-error-handling-media-remove-orphans branch from dd406e2 to d5d2c6f Compare December 8, 2019 21:56
@Gargron Gargron merged commit d7bcc09 into master Dec 9, 2019
@Gargron Gargron deleted the fix-error-handling-media-remove-orphans branch December 9, 2019 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants