Enhancements in Track Handling and Artist Recognition for Yandex Music #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e token owner available) Implemented recognition of track links without specifying the album, e.g., https://music.yandex.ru/track/75370207 Now, if a track has multiple artists, all of them will be listed in the author field instead of just one.
…e token owner available) Implemented recognition of track links without specifying the album, e.g., https://music.yandex.ru/track/75370207 Now, if a track has multiple artists, all of them will be listed in the author field instead of just one.
|
@AgutinVBoy any chance you can check this out? |
Ok. In the day. |
AgutinVBoy
suggested changes
Oct 25, 2023
main/src/main/java/com/github/topi314/lavasrc/yandexmusic/YandexMusicSourceManager.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/yandexmusic/YandexMusicSourceManager.java
Show resolved
Hide resolved
topi314
reviewed
Oct 25, 2023
main/src/main/java/com/github/topi314/lavasrc/yandexmusic/YandexMusicSourceManager.java
Outdated
Show resolved
Hide resolved
fix issue when some playlists don't provide track info
|
is this done? or what is the current status on this? |
|
@topi314 Sorry, was on vacation. Yes, its done in my understanding |
|
your branch is 11 commits behind master, can you please first merge before I take a look? |
|
Done |
topi314
requested changes
Jan 23, 2024
There was a problem hiding this comment.
please also update the supported links in the readme https://github.com/topi314/LavaSrc#yandex-music-1
main/src/main/java/com/github/topi314/lavasrc/yandexmusic/YandexMusicSourceManager.java
Outdated
Show resolved
Hide resolved
…exMusicSourceManager.java Co-authored-by: Toπ <git@topi.wtf>
add new supported link
|
done |
topi314
requested changes
Feb 17, 2024
main/src/main/java/com/github/topi314/lavasrc/yandexmusic/YandexMusicSourceManager.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/yandexmusic/YandexMusicSourceManager.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/yandexmusic/YandexMusicSourceManager.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/yandexmusic/YandexMusicSourceManager.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/yandexmusic/YandexMusicSourceManager.java
Outdated
Show resolved
Hide resolved
…exMusicSourceManager.java Co-authored-by: Toπ <git@topi.wtf>
…exMusicSourceManager.java Co-authored-by: Toπ <git@topi.wtf>
…exMusicSourceManager.java Co-authored-by: Toπ <git@topi.wtf>
…exMusicSourceManager.java Co-authored-by: Toπ <git@topi.wtf>
topi314
approved these changes
Mar 5, 2024
|
alright thanks for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for manually uploaded tracks (only those uploaded by the token owner available)
Implemented recognition of track links without specifying the album, e.g., https://music.yandex.ru/track/75370207
Now, if a track has multiple artists, all of them will be listed in the author field instead of just one.