Fixed mp3 frame not found. #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error was caused by selecting the first track without checking the codec
|
ah that makes sense, lavaplayer can also play aac tracks fyi |
topi314
reviewed
May 14, 2024
| .filter(c -> c.get("codec").text().equals("mp3")) | ||
| .max(Comparator.comparingInt(b -> b.get("bitrateInKbps").as(Integer.class))) | ||
| .map(d -> d.get("downloadInfoUrl").text()) | ||
| .orElse(null); |
There was a problem hiding this comment.
I'll do a comit when I get home, didn't know about orElseThrow. :>
There was a problem hiding this comment.
you can use
orElseThrowhere
Do I fix it or don't I need to fix it?
topi314
reviewed
May 14, 2024
main/src/main/java/com/github/topi314/lavasrc/yandexmusic/YandexMusicAudioTrack.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Toπ <git@topi.wtf>
Yes, it makes sense when checking for codec type. But there is no codec type check in the code, Mp3Track is used right away. |
|
feel free to add support for this if you want, else this is ready to merge |
Doesn't make sense as yandex always gives mp3. |
topi314
approved these changes
May 14, 2024
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error was caused by selecting the first track without checking the codec.