Local File Support #206
Merged
Local File Support #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
while this code looks decent, what happens when you try to play a local file? |
|
Nothing. Me personally I handled it with my client. I sift through the playlist results, and then recorrect the local file tracks to a proper format by searching for it. |
|
Do you have an example playlist for me to test? |
|
This playlists first track is a local file while the second track isn't. In total there should be 104 tracks including local files and 94 tracks excluding local files. https://open.spotify.com/playlist/5vJw9wsX5MTkhkSiY04bIw?si=7kT0rDfgQkSkzHhKcZ6tHQ |
|
can you also please update the docs in the readme? |
…tify tracks, and change unknown fields to local
topi314
requested changes
Jul 19, 2024
main/src/main/java/com/github/topi314/lavasrc/spotify/SpotifySourceManager.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/spotify/SpotifySourceManager.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Toπ <git@topi.wtf>
Co-authored-by: Toπ <git@topi.wtf>
|
All changes implemented. |
topi314
reviewed
Jul 20, 2024
main/src/main/java/com/github/topi314/lavasrc/spotify/SpotifySourceManager.java
Outdated
Show resolved
Hide resolved
topi314
reviewed
Jul 20, 2024
main/src/main/java/com/github/topi314/lavasrc/spotify/SpotifySourceManager.java
Outdated
Show resolved
Hide resolved
|
All changes implemented. |
topi314
reviewed
Jul 21, 2024
main/src/main/java/com/github/topi314/lavasrc/spotify/SpotifySourceManager.java
Outdated
Show resolved
Hide resolved
topi314
approved these changes
Jul 22, 2024
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Spotify local files and included an option for this feature in the configuration.