-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Vk Music Source Manager #207
Conversation
I hope for a fairly quick review of this pr. |
since this pr seems to be active again, how long should I wait before reviewing it? |
Idk 😅 but for me personally I'm all set, it's just that I've been informed that the lyric in the vk may still give it with timestamps |
you want to rebase this pr onto master, there have been some readme changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also move all your stuff to the bottom and not inbetween existing audio sources?
notably documentation (README) & config
main/src/main/java/com/github/topi314/lavasrc/vkmusic/VkMusicSourceManager.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/vkmusic/VkMusicAudioTrack.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/vkmusic/VkMusicSourceManager.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/vkmusic/VkMusicSourceManager.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/vkmusic/VkMusicSourceManager.java
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/vkmusic/VkMusicSourceManager.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/vkmusic/VkMusicSourceManager.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/vkmusic/VkMusicSourceManager.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/vkmusic/VkMusicSourceManager.java
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/vkmusic/VkMusicAudioTrack.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/vkmusic/VkMusicSourceManager.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/vkmusic/VkMusicSourceManager.java
Show resolved
Hide resolved
plugin/src/main/java/com/github/topi314/lavasrc/plugin/LavaSrcPlugin.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/com/github/topi314/lavasrc/plugin/LavaSrcPlugin.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/com/github/topi314/lavasrc/plugin/LavaSrcPlugin.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/com/github/topi314/lavasrc/plugin/SourcesConfig.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/com/github/topi314/lavasrc/plugin/SourcesConfig.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please resolve conversations when you fixed what I asked there, else I need to check every single one of them myself.
not sure where those spaces come from but there is a .editorconfig
which should let you simply format lavasrc.
main/src/main/java/com/github/topi314/lavasrc/vkmusic/VkMusicSourceManager.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/com/github/topi314/lavasrc/plugin/LyricsSourcesConfig.java
Show resolved
Hide resolved
plugin/src/main/java/com/github/topi314/lavasrc/plugin/VkMusicConfig.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/com/github/topi314/lavasrc/plugin/LavaSrcPlugin.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/com/github/topi314/lavasrc/plugin/LavaSrcPlugin.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this finally looks acceptable to me
thanks |
No description provided.