-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/delegating lookup #44
Conversation
main/src/main/java/com/github/topisenpai/lavasrc/applemusic/AppleMusicSourceManager.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topisenpai/lavasrc/mirror/MirroringAudioTrack.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topisenpai/lavasrc/spotify/SpotifySourceManager.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topisenpai/lavasrc/mirror/DelegatedAudioLookup.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topisenpai/lavasrc/mirror/MirroringAudioSourceManager.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topisenpai/lavasrc/mirror/MirroringAudioTrack.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topisenpai/lavasrc/mirror/MirroringAudioTrack.java
Outdated
Show resolved
Hide resolved
…e some minor stuff around
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved & renamed some minor stuff. Like this it should be good to go. Let me know your thoughts
I'm alright with the name change, but it's hard to tell what changed in the diff. Did you intend to change all the spaces to tabs? |
Works for me, go ahead and merge. As a side note, 4 spaces is much more standard than using tabs, but feel free to use whatever you prefer. |
ty for the contribution |
The DelegatedAudioLookup function allows the track lookup behavior to be injectable by the client application. This may be desired when isrc/name match lookup is not good enough, and additional logic needs to be applied.
Sample usage: