-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore images flashes an init_boot backup to the boot partition #8211
Comments
The rooted init_boot partition's
And the backup is at So those matching correctly should hopefully narrow the location of the fault down a bit. |
This comment was marked as outdated.
This comment was marked as outdated.
It was definitely working for me on 27002. I didn't test really with 27003 since it couldn't Direct Install while the app was hidden. Edit: I quickly rolled back to 27003 unhidden to test and it restored images without issue, so this is confirmed a new regression as of 27004, at least on my devices. |
Oh, I forgot to mention that I had created multiple tags between |
Still present in 27006, apparently. Glad I found this issue report before struggling any further, I just migrated from Kitsune-27003 to Magisk (Canary) 27006, and thought I'd screwed up the stock backup in the process. Hopefully this regression gets fixed at some point, or OTA updates are going to be a bit more of a PITA. |
any solution? seems doesn't affect OTA. my pixel 6 and 7 just updated to Android 15 beta 4.2 and I install magisk to another slot and it works |
For whatever reason, my Pixel 8 Pro never even recognizes an OTA update is available for download until I (temporarily) uninstall Magisk by restoring images before checking, which is what's currently broken in 27004-27006. |
That part is expected behavior. But yeah, no way to restore images right now except manually from these app regressions, which is frustrating. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
Oh wait, nope, now it'll show "Restoration done!" but next doing a Direct Install still shows "Magisk patched boot image detected", meaning the restore didn't actually happen. 🤔 |
@osm0sis I tested the feature on my own device and it's working properly |
I'll try again in the new Canary, but it's definitely not doing anything in 27007. It reports "Restoration done!" but doesn't actually restore. |
Managed to brick my Pixel 8 Pro doing rapid fire Restore Images and Direct Installs, not sure exactly why/how, but anyway, seemed pretty clear that it was still broken exactly as I described 3 weeks ago, even with a fresh init_boot backup from the Magisk app: #8211 (comment) Anyway, hopefully someone else can confirm the issue is ongoing, since I'll be out of commission for a while. |
Okay, maybe I'm not crazy (regarding this issue, anyway). My experience still exactly parallels yours: Uninstall (Restore Images) claims to work, but subsequent Direct Install detects an already-patched image. And then after updating to 27008 and rebooting, my Pixel 8 Pro was also bricked ("boot failure," etc.) until I downloaded and flashed the latest factory (not OTA) image with no wipe. Like you, even flashing my previously-patched or stock init_boot didn't help, only the full factory image. I'm back up and running 27008, but sure don't trust messing with its alleged uninstall and direct install yet. |
Getting off topic, but even worse, I tried to Either way, sounds like there is in fact something still off with Restore Images, so I'll reopen this, and then perhaps also some investigation is warranted by the developers with either multiple subsequent Direct Installs, or perhaps with 27008 Direct Installed over itself, to see what's getting corrupted that would necessitate a Factory Image flash. If you wouldn't mind soft bricking yours again for science, you should try to see exactly which partition needed to be flashed to fix it, which might shed some light on the matter overall. 🤞 |
Just to be clear, can anyone confirm whether the bootloop happens only after restoring images? This sounds more than likely to be a new regression at magiskinit level 🤔 |
I definitely had updated 27007 to 27008 and rebooted with all working to that point, before testing out Restore Images and Direct Install led me to the bigger issues. Sounds like @Bennett-69 currently has 27008 running as well. |
Re-checked the image from /data/magisk_backup and it seems the image is correct... Not sure how it fails... |
Maybe it's the same problem. I used magisk27008 version to restore the original image. My init_boot was mistakenly flashed into the boot partition. I downloaded the original package to extract the boot and flashed it manually, and it can boot correctly. He did not modify the init_boot partition. The above problem occurred on Meizu 20 and Meizu 21Pro |
Something flashed to the wrong partition at some point was my guess for what happened to me, going to see if I can reproduce and confirm it when I get my warranty replacement Pixel 8 Pro. 🧐 |
I can confirm the boot failure after a single Restore Images attempt on my replaced Pixel 8 Pro, and that immediately flashing only the stock boot.img to the boot partition gets it working again. So, must be that Restore Images is sending the init_boot .img in the backup to the boot partition by mistake, and thus leaving init_boot partition rooted as previously noted. |
It seems that the issue I faced on a Pixel 6a is different: Restoring image flashes nothing to the boot partition 🤔 |
I might've used a device that's too old for testing. Let me try one with init_boot instead |
I believe the |
How could $SLOT being missing result in flashing to boot instead of init_boot on an A/B init_boot device? |
Missing slot will cause |
Device: Pixel 8 Pro
Android version: 14 (Stock)
Magisk version name: b38ab2a
Magisk version code: 27004
Steps to reproduce:
Log excerpt:
Edit: Some progress was made with e6bd2ff but now the issue is that it shows "Restoration done!" but the image was never actually restored.
See #8211 (comment)
The text was updated successfully, but these errors were encountered: