-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old metrics #126
Remove old metrics #126
Conversation
1e0640e
to
db39a5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please review constants.go
? Some values are not used.
ProbeThreshold string `json:"probeThreshold"` | ||
NodeSelector corev1.NodeSelector `json:"nodeSelector"` | ||
|
||
//+kubebuilder:validation:Maximum:=59 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If parameters are required, woud you please add +kubebuilder:validation:Required
annotation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f0c33be
to
36f60e1
Compare
@llamerada-jp @cupnes I updated my code, so could you review this PR again? The changes I made since you reviewed are as follows: https://github.com/topolvm/pie/compare/db39a5b5ab5592f4719d10b8a8843abd93567a7c..36f60e1#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5 |
36f60e1
to
cb624a9
Compare
monitoringStorageClass: YOUR-STORAGE-CLASS-NAME # This field is mandatory. | ||
# All other fields are optional. | ||
nodeSelector: | ||
nodeSelectorTerms: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the indentation is too much.
nodeSelectorTerms: | |
nodeSelectorTerms: |
# All other fields are optional. | ||
nodeSelector: | ||
nodeSelectorTerms: | ||
- matchExpressions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto.
- matchExpressions: | |
- matchExpressions: |
nodeSelector: | ||
nodeSelectorTerms: | ||
- matchExpressions: | ||
- key: foo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto.
- key: foo | |
- key: foo |
README.md
Outdated
nodeSelectorTerms: | ||
- matchExpressions: | ||
- key: foo | ||
operator: DoesNotExist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto. (I think it would be good to remove four half-width spaces here.)
operator: DoesNotExist | |
operator: DoesNotExist |
cb624a9
to
e8f5a07
Compare
This commit removes the following metrics: - pie_io_write_latency_seconds - use pie_io_write_latency_on_mount_probe_seconds instead - pie_io_read_latency_seconds - use pie_io_read_latency_on_mount_probe_seconds instead - pie_create_probe_total - use pie_mount_probe_total or pie_provision_probe_total instead - pie_performance_probe_total - use pie_performance_on_mount_probe_total instead Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
e8f5a07
to
1c01d73
Compare
This commit removes the following metrics:
- use pie_io_write_latency_on_mount_probe_seconds instead
- use pie_io_read_latency_on_mount_probe_seconds instead
- use pie_mount_probe_total or pie_provision_probe_total instead
- use pie_performance_on_mount_probe_total instead