Remove old metrics #126
Merged
Remove old metrics #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ushitora-anqou
force-pushed
the
remove-old-metrics
branch
4 times, most recently
from
1e0640e
to
db39a5b
Compare
llamerada-jp
requested changes
Jun 7, 2024
| ProbeThreshold string `json:"probeThreshold"` | ||
| NodeSelector corev1.NodeSelector `json:"nodeSelector"` | ||
|
|
||
| //+kubebuilder:validation:Maximum:=59 |
There was a problem hiding this comment.
If parameters are required, woud you please add +kubebuilder:validation:Required annotation?
cupnes
reviewed
Jun 7, 2024
ushitora-anqou
force-pushed
the
remove-old-metrics
branch
2 times, most recently
from
f0c33be
to
36f60e1
Compare
|
@llamerada-jp @cupnes I updated my code, so could you review this PR again? The changes I made since you reviewed are as follows: https://github.com/topolvm/pie/compare/db39a5b5ab5592f4719d10b8a8843abd93567a7c..36f60e1#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5 |
cupnes
reviewed
Jun 11, 2024
ushitora-anqou
force-pushed
the
remove-old-metrics
branch
from
36f60e1
to
cb624a9
Compare
cupnes
reviewed
Jun 12, 2024
| monitoringStorageClass: YOUR-STORAGE-CLASS-NAME # This field is mandatory. | ||
| # All other fields are optional. | ||
| nodeSelector: | ||
| nodeSelectorTerms: |
There was a problem hiding this comment.
I think the indentation is too much.
Suggested change
| nodeSelectorTerms: | |
| nodeSelectorTerms: |
| # All other fields are optional. | ||
| nodeSelector: | ||
| nodeSelectorTerms: | ||
| - matchExpressions: |
There was a problem hiding this comment.
ditto.
Suggested change
| - matchExpressions: | |
| - matchExpressions: |
| nodeSelector: | ||
| nodeSelectorTerms: | ||
| - matchExpressions: | ||
| - key: foo |
There was a problem hiding this comment.
ditto.
Suggested change
| - key: foo | |
| - key: foo |
README.md
Outdated
| nodeSelectorTerms: | ||
| - matchExpressions: | ||
| - key: foo | ||
| operator: DoesNotExist |
There was a problem hiding this comment.
ditto. (I think it would be good to remove four half-width spaces here.)
Suggested change
| operator: DoesNotExist | |
| operator: DoesNotExist |
ushitora-anqou
force-pushed
the
remove-old-metrics
branch
from
cb624a9
to
e8f5a07
Compare
This commit removes the following metrics:
- pie_io_write_latency_seconds
- use pie_io_write_latency_on_mount_probe_seconds instead
- pie_io_read_latency_seconds
- use pie_io_read_latency_on_mount_probe_seconds instead
- pie_create_probe_total
- use pie_mount_probe_total or pie_provision_probe_total instead
- pie_performance_probe_total
- use pie_performance_on_mount_probe_total instead
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
ushitora-anqou
force-pushed
the
remove-old-metrics
branch
from
e8f5a07
to
1c01d73
Compare
llamerada-jp
approved these changes
Jun 12, 2024
cupnes
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the following metrics:
- use pie_io_write_latency_on_mount_probe_seconds instead
- use pie_io_read_latency_on_mount_probe_seconds instead
- use pie_mount_probe_total or pie_provision_probe_total instead
- use pie_performance_on_mount_probe_total instead