Support deploying provision probe or mount probe only #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ushitora-anqou
changed the title
ushitora-anqou
force-pushed
the
support-deploying-provision-probe-only
branch
3 times, most recently
from
0541fa9
to
6828adf
Compare
daichimukai
reviewed
Aug 13, 2024
There was a problem hiding this comment.
I'm confused with namings of added fields and something like that. Are they expected to be singular form, or plural form?
- As struct fields, both are plural:
DisableProvisionProbes,DisableMountProbes. - As yaml fields, both are singular:
disableProvisionProbe,disableMountProbe. - Reconcilers have mixed form:
reconcileProvisionProbe,reconcileMountProbes.
At least it seems to me that we should use singular form for the "provision probe" as it creates exactly one CronJob. On the other hand I think both singular form and plural form are reasonable for the "mount probe". I'm happy if only one of them is consistently used, anyway.
Currently, when a user deploys a PieProbe object, both of the provision probe and the mount probes are deployed. However, under some circumstances, it is enough to deploy either the provision probe or the mount probes only. This commit supports deploying either the provision probe or the mount probes only, by adding disableProvisionProbe and disableMountProbes fields to PieProbe spec. Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
ushitora-anqou
force-pushed
the
support-deploying-provision-probe-only
branch
from
6828adf
to
2306138
Compare
|
Thanks for your feedback. I fixed my code to use the names |
daichimukai
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a user deploys a PieProbe object, both of provision and
mount probes are deployed. However, under some circumstances, it is
enough to deploy either provision probes or mount probes only.
This commit supports deploying either provision probes or mount probes
only, by adding disableProvisionProbes and disableMountProbes fields to
PieProbe spec.
Signed-off-by: Ryotaro Banno ryotaro.banno@gmail.com