-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce wait time between resizes #274
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Nam Hai Nguyen <namhai.nguyen-ext@commercetools.com>
Could you please tell me more about the AWS storage behavior, limitations, etc. that would explain why this feature is needed? For example, are there any side effects, such as charges for performing resizing at high frequencies? |
This is the limitation of AWS EBS volumes:
I'm not aware of any additional charges for high API requests, but having this time check would reduce the useless API calls up to 6 hours . |
I have read the document you gave me and it reads that the 6h is a guideline and nothing is guaranteed for the time. It is also unclear what actually happens if this is not adhered to. What are the real issues that have occurred at your site? |
Yes, 6h is just the guideline and I could set to any thing >= 6h to "comply" with AWS. This is not a big issue but optimization for the known limitations, we (ops) know that don't bother to increase the EBS volume size again if it's just resized in < 6h, then the controller should behave the same. |
Upon investigation, I found that modifying the pvc-autoresizer does not satisfy the guidelines. First, the guidelines say to ensure if it is in use or available, but it is not possible to ensure these states by the pvc-autoresizer. Also, it cannot handle cases where the PVC has been edited by another controller or manually. |
I'd like to add support for pvc-autoresizer controller to wait x hours between resizes to comply with cloud providers like AWS.