[DEVX-4047] Bump rubocop to latest and fix offenses #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@toptal-anvil ping reviewers |
lstrzebinczyk
force-pushed
the
devx-4047
branch
2 times, most recently
from
65cfb00 to
042298f
Compare
kml
approved these changes
May 10, 2024
mbie
approved these changes
May 10, 2024
| subject.email = login | ||
| subject.save! | ||
| user.email = login | ||
| user.save! |
There was a problem hiding this comment.
Rubocop asked me to, and even though it incorrectly applied it's rule, I feel like this is a good move.
| @@ -11,7 +9,7 @@ def self.defaults! | |||
| path = CONFIG_DEFAULT.to_s | |||
| hash = ConfigLoader.load_file(path) | |||
| config = Config.new(hash, path).tap(&:make_excludes_absolute) | |||
| puts "configuration from #{path}" if ConfigLoader.debug? | |||
| Rails.logger.debug { "configuration from #{path}" } if ConfigLoader.debug? | |||
There was a problem hiding this comment.
What do you think about using global logger?
Suggested change
| Rails.logger.debug { "configuration from #{path}" } if ConfigLoader.debug? | |
| Granite::Form.config.logger.debug { "configuration from #{path}" } if ConfigLoader.debug? |
I do not see much usage of loggers in the repository but anyway it would be good to keep it generic.
There was a problem hiding this comment.
This was an automatic change by rubocop. We can discuss further changes as separate tickets @mbie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated rubocop, rubocop-rspec and rubocop-rails to the latest version, removed all of the rule overwriting and fixed the violations. Disabled 3 rules, which proved to be time consuming to fix.
Review
Pre-merge checklist
master(if not - rebase it).