Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade davinci to 12 version #2620

Merged
merged 3 commits into from
Apr 18, 2022
Merged

chore: upgrade davinci to 12 version #2620

merged 3 commits into from
Apr 18, 2022

Conversation

dmaklygin
Copy link
Contributor

@dmaklygin dmaklygin commented Apr 11, 2022

Description

in order to upgrade ESLint to 8 version in Davinci. We need to apply the latest Davinci version in Picasso.

How to test

  • Conduct all CI jobs

Review

PR commands

List of available commands:

  • @toptal-bot run all - Run whole pipeline
  • @toptal-bot run build - Check build
  • @toptal-bot run visual - Run visual tests
  • @toptal-bot run deploy:documentation - Deploy documentation
  • @toptal-bot run package:alpha-release - Release alpha version
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2022

⚠️ No Changeset found

Latest commit: d9ff33d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dmaklygin dmaklygin force-pushed the check-eslint-upgrade branch 2 times, most recently from d599e40 to 3bfc039 Compare April 15, 2022 11:41
@dmaklygin dmaklygin changed the title Check eslint 8 chore: upgrade davinci to 12 version Apr 15, 2022
@dmaklygin dmaklygin self-assigned this Apr 15, 2022
@dmaklygin dmaklygin force-pushed the check-eslint-upgrade branch from f4606fc to f7286ac Compare April 15, 2022 13:08
Copy link
Contributor

@TomasSlama TomasSlama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

jest-setup.ts Outdated Show resolved Hide resolved
@dmaklygin dmaklygin marked this pull request as ready for review April 18, 2022 09:53
@dmaklygin dmaklygin requested a review from a team April 18, 2022 09:53
@dmaklygin dmaklygin force-pushed the check-eslint-upgrade branch from 316b38e to f43c8a7 Compare April 18, 2022 11:56
@dmaklygin dmaklygin force-pushed the check-eslint-upgrade branch from f43c8a7 to d9ff33d Compare April 18, 2022 13:27
@toptal-devbot
Copy link
Collaborator

🎉 Last commit is successfully deployed 🎉

Demo is available on:

Your davinci-bot 🚀

@dmaklygin dmaklygin merged commit f9b39d9 into master Apr 18, 2022
@dmaklygin dmaklygin deleted the check-eslint-upgrade branch April 18, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants