-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade davinci to 12 version #2620
Conversation
|
d599e40
to
3bfc039
Compare
f4606fc
to
f7286ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪
316b38e
to
f43c8a7
Compare
f43c8a7
to
d9ff33d
Compare
🎉 Last commit is successfully deployed 🎉 Demo is available on: Your davinci-bot 🚀 |
Description
in order to upgrade ESLint to 8 version in Davinci. We need to apply the latest Davinci version in Picasso.
How to test
Review
props
in component with documentationexamples
for componentyarn test
yarn test:visual
. If not - check the documentation how to fix visual testsPR commands
List of available commands:
@toptal-bot run all
- Run whole pipeline@toptal-bot run build
- Check build@toptal-bot run visual
- Run visual tests@toptal-bot run deploy:documentation
- Deploy documentation@toptal-bot run package:alpha-release
- Release alpha versionPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?